Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the style of busuanzi, tag cloud and read more button #561

Merged
merged 4 commits into from
Jan 3, 2019
Merged

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Jan 3, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved N/A

2019-01-03 3 45 30

2019-01-03 3 47 23

2019-01-03 4 30 46

What is the new behavior?

Description about this pull, in several words...

  • Screens with this changes: N/A
  • Link to demo site with this changes: N/A
    2019-01-03 3 45 53

2019-01-03 3 46 48

2019-01-03 4 31 13
2019-01-03 11 00 03

Modified source/css/_common/components/tag-cloud.styl
and source/css/_schemes/Gemini/index.styl
and layout/_third-party/analytics/busuanzi-counter.swig
and source/css/_common/components/third-party/third-party.styl

Also, source/css/_common/components/third-party/busuanzi-counter.styl can be removed.

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

<span class="busuanzi-value" id="busuanzi_value_site_uv"></span>
</span>
{% endif %}

{% if theme.busuanzi_count.total_visitors and theme.busuanzi_count.total_views %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Mb not need divider here? Because it's one plugin.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an option for users to decide then ?

Copy link
Contributor Author

@stevenjoezhang stevenjoezhang Jan 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The separator | is displayed in NexT v5.x . Related to theme-next/theme-next.org#7

Copy link
Member

@ivan-nginx ivan-nginx Jan 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean about internal | separator.

This is pretty:
image

This is not so nice:
image


Separator almost is a delimeter between different categories or plugins.

Copy link
Member

@ivan-nginx ivan-nginx Jan 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But, if you want this separator, need to add style like this:

image

There is space between and after item.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's added, I forget to update the screenshot.
2019-01-03 11 00 03
It looks fine

@ivan-nginx ivan-nginx added this to the v7.0.0 milestone Jan 3, 2019
@ivan-nginx ivan-nginx added the v6.x label Jan 3, 2019
@ivan-nginx ivan-nginx merged commit a875716 into theme-next:master Jan 3, 2019
@stevenjoezhang stevenjoezhang changed the title Optimize stylesheet Optimize the style of busuanzi, tag cloud and read more button Jan 5, 2019
@ivan-nginx ivan-nginx removed the Support label Jan 7, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
* Update tag-cloud.styl

* Update index.styl

* Update busuanzi-counter.swig

* Update third-party.styl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants