Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename theme.vendors.Han to theme.vendors.han #512

Merged
merged 1 commit into from
Dec 16, 2018
Merged

Rename theme.vendors.Han to theme.vendors.han #512

merged 1 commit into from
Dec 16, 2018

Conversation

Maples7
Copy link
Contributor

@Maples7 Maples7 commented Dec 16, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes have been added (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue Number(s): #510

What is the new behavior?

Description about this pull, in several words...

  • Screens with this changes: rename vendors.Han to vendors.han in _config.yml
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

vendors:
  han: http://blabla.com/Han/min/3.3.0.css
...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@ivan-nginx
Copy link
Member

@Maples7 tested, worked?

@ivan-nginx ivan-nginx added this to the v6.6.1 milestone Dec 16, 2018
@ivan-nginx ivan-nginx merged commit dccc2a3 into theme-next:master Dec 16, 2018
@ivan-nginx ivan-nginx changed the title rename theme.vendors.Han to theme.vendors.han Rename theme.vendors.Han to theme.vendors.han Dec 16, 2018
@Maples7
Copy link
Contributor Author

Maples7 commented Dec 16, 2018

Tested.
For me, that's re-introducing issue #508...

tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
rename theme.vendors.Han to theme.vendors.han
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants