Add beian option at footer for Chinese website owner #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-nginx
reviewed
Oct 10, 2018
| @@ -1,6 +1,9 @@ | |||
| <div class="copyright">{# | |||
| #}{% set current = date(Date.now(), "YYYY") %}{# | |||
| #}© {% if theme.footer.since and theme.footer.since != current %}{{ theme.footer.since }} – {% endif %}{# | |||
There was a problem hiding this comment.
Here is not —. Here is n-dash (this: –, not that: —)
There was a problem hiding this comment.
ok, &mdash will be displaced.
MoshiCoCo
reviewed
Jan 16, 2019
| @@ -1,6 +1,9 @@ | |||
| <div class="copyright">{# | |||
| #}{% set current = date(Date.now(), "YYYY") %}{# | |||
| #}© {% if theme.footer.since and theme.footer.since != current %}{{ theme.footer.since }} – {% endif %}{# | |||
| #}{% if theme.footer.beian.enable %}{# | |||
| #}<a target="_blank" rel="external nofollow" href="http://www.miitbeian.gov.cn/"> {{theme.footer.beian.icp}} </a>{# | |||
There was a problem hiding this comment.
I opened the "beian" option today and found that the "beian" option and "since2015" are crowded on the same line. It is not very beautiful. If you display the "beian" message text on a separate line, it will be more beautiful.
There was a problem hiding this comment.
You can create your own pull request with this changes. Welcome!
There was a problem hiding this comment.
You can create your own pull request with this changes. Welcomeo'k!
ok，thanks reply。
stevenjoezhang
changed the title
15 tasks
tongluyang
pushed a commit
to tongluyang/hexo-theme-next
that referenced
this pull request
Nov 19, 2019
* finish beian featrue * update style * replace mdash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number(s): N/A
What is the new behavior?
ADD:
beianoption in_config.yml-theme-footer.How to use?
In NexT
_config.yml:Does this PR introduce a breaking change?