Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove box-shadow of .sidebar when back2top.sidebar is true #1380

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

backrunner
Copy link
Contributor

PR Checklist

  • The commit message follows guidelines for NexT.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

image

The back2top button can't apply the shadow, it looks uncomfortable.

What is the new behavior?

I removed the shadow of sidebar when back2top.sidebar is true.

  • Screenshots with this changes:
    image

Does this PR introduce a breaking change?

  • Yes.
  • No.

@stevenjoezhang stevenjoezhang added this to the 7.7.2 milestone Feb 16, 2020
@stevenjoezhang stevenjoezhang merged commit 0699f4c into theme-next:master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants