Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor reading-progress #1100

Merged
merged 5 commits into from
Aug 16, 2019
Merged

Refactor reading-progress #1100

merged 5 commits into from
Aug 16, 2019

Conversation

stevenjoezhang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@1v9 1v9 added this to the v7.4.0 milestone Aug 16, 2019
@theme-next theme-next deleted a comment Aug 16, 2019
@theme-next theme-next deleted a comment Aug 16, 2019
@stevenjoezhang
Copy link
Contributor Author

Use innerText instead of innerHTML?

@theme-next theme-next deleted a comment Aug 16, 2019
@1v9 1v9 merged commit bd86c22 into master Aug 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the progress branch August 16, 2019 05:27
@ivan-nginx
Copy link
Member

InnerHTML for all viewport, right? How about comments lazyloading?

tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants