Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix if not is post show the commit #1085

Closed
wants to merge 1 commit into from
Closed

fix if not is post show the commit #1085

wants to merge 1 commit into from

Conversation

Mryan2005
Copy link

@Mryan2005 Mryan2005 commented Aug 12, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@welcome
Copy link

welcome bot commented Aug 12, 2019

Thanks so much for opening your first PR here!

@CLAassistant
Copy link

CLAassistant commented Aug 12, 2019

CLA assistant check
All committers have signed the CLA.

@stevenjoezhang
Copy link
Contributor

stevenjoezhang commented Aug 12, 2019

What's the difference? {%- if page.comments %} is enough to make comments only display on pages and posts

@Mryan2005
Copy link
Author

but you can't stop show it in Tag page and categoriespage

@Mryan2005
Copy link
Author

@stevenjoezhang

@stevenjoezhang
Copy link
Contributor

stevenjoezhang commented Aug 12, 2019

You can take a look at the discussion in this PR: #1039

Comments can be disabled by setting comments to false in Front-matter. In other words, users have the right to choose whether the comments display in tags or archive page.
However, this PR fully disabled the comments in all pages (not only tags or archive, but all custom pages). Users can't enable comments without modifying source code.

And, you only modified the code for livere. So this PR may not match your own expectations.

@Mryan2005
Copy link
Author

ok. I see

@Mryan2005 Mryan2005 closed this Aug 12, 2019
@Mryan2005 Mryan2005 deleted the patch-1 branch August 12, 2019 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants