Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several bugs reported in v7.3 #1060

Merged
merged 5 commits into from
Aug 9, 2019
Merged

Fix several bugs reported in v7.3 #1060

merged 5 commits into from
Aug 9, 2019

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Aug 5, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

Copy link
Member

@ivan-nginx ivan-nginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask why u remove active-menu selector from backend and add it to frontend? Just try to force refresh browser (CTRL+SHIFT+R) and see what happen: in your variant menu will be selected not instantly.

@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Aug 5, 2019

It's for PJAX and cache. Because menu items on every page is same, the only difference is the active one. So move the script to the front-end would be better.

Otherwise PJAX have to refresh the whole menu... and the animation (velocity & motion) have to play again... it's too complicated
That's why I decided to use front-end script to highlight the active one

@ivan-nginx
Copy link
Member

PJAX don't work with backend?

@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Aug 5, 2019

PJAX will load the whole page, and replace the specified elements, e.g. sidebar

@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Aug 5, 2019

屏幕快照 2019-08-05 上午11 48 18

I did not change the style of RSS or Chat during the reconstruction of the font size. Now Chat looks normal but RSS lacks margin...

5px margin added

@stevenjoezhang stevenjoezhang marked this pull request as ready for review August 8, 2019 05:10
@stevenjoezhang stevenjoezhang added this to the v7.4.0 milestone Aug 8, 2019
@stevenjoezhang stevenjoezhang mentioned this pull request Aug 8, 2019
8 tasks
@stevenjoezhang stevenjoezhang merged commit 692f148 into master Aug 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix branch August 9, 2019 07:41
@1v9 1v9 added the PJAX label Aug 19, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants