-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix several bugs reported in v7.3 #1060
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I ask why u remove active-menu selector from backend and add it to frontend? Just try to force refresh browser (CTRL+SHIFT+R) and see what happen: in your variant menu will be selected not instantly.
It's for PJAX and cache. Because menu items on every page is same, the only difference is the active one. So move the script to the front-end would be better. Otherwise PJAX have to refresh the whole menu... and the animation (velocity & motion) have to play again... it's too complicated |
PJAX don't work with backend? |
PJAX will load the whole page, and replace the specified elements, e.g. sidebar |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue resolved: N/A
What is the new behavior?
How to use?
In NexT
_config.yml
:Does this PR introduce a breaking change?