Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site overview reload on every page with PJAX enabled. #1084

Closed
3 tasks done
gapplef opened this issue Aug 11, 2019 · 5 comments · Fixed by #1113
Closed
3 tasks done

Site overview reload on every page with PJAX enabled. #1084

gapplef opened this issue Aug 11, 2019 · 5 comments · Fixed by #1113

Comments

@gapplef
Copy link

gapplef commented Aug 11, 2019

I agree and want to create new issue

Site Overview in the sidebar is keep unchanged in most cases, like all the pages under home, the archive page, the about page, the tags page, the categories pages and all the post pages without Table of Contents(ToC).

Actually, only for posts with ToC, the Site Overview will combined with ToC, thus need to refresh. But with PJAX turn on, the Site Overview always reload on every page.

Is it possible to only reload the Site Overview when necessary?

@gapplef gapplef added the Bug label Aug 11, 2019
@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue. See dashboard for more details.

@gapplef
Copy link
Author

gapplef commented Aug 11, 2019

@stevenjoezhang Why would it considered as a feature?
I mean Site Overview is unchanged in most cases, why it need to be reload?

Reload Site Overview while keep Menu fixed is counter-intuition, as both are unchanged!
The user experience would be better to reload the Site Overview only when necessary.

@stevenjoezhang
Copy link
Contributor

stevenjoezhang commented Aug 11, 2019

Since there is no backend support, PJAX always loads the entire page. So this does not save http traffic.

However, you can still follow your ideas and open a pull request~

@gapplef
Copy link
Author

gapplef commented Aug 12, 2019

Only if I know how to deal with all those JS/CSS stuff 😂

Anyway, really appreciate your active work on NexT theme 👍 @stevenjoezhang

@stevenjoezhang
Copy link
Contributor

Fixed in #1113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants