Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for geodesic Sinkhorn #638

Closed
MUCDK opened this issue Dec 11, 2023 · 1 comment
Closed

add tests for geodesic Sinkhorn #638

MUCDK opened this issue Dec 11, 2023 · 1 comment
Assignees

Comments

@MUCDK
Copy link
Collaborator

MUCDK commented Dec 11, 2023

In #633 , we currently only have tests for the TemporalProblem. As the pipeline for a graph-based cost is quite different from the remaining costs, we need tests for all problems. Moreover, we should test for different configurations of costs, e.g. linear term geodesic, quadratic terms Euclidean.

Finally, we need examples on how to use the geodesic cost. Here, I would suggest one example notebook for multiple time points with the TemporalProblem, and one FGW problem (e.g. TranslationProblem) with the linear term being geodesic, and the quadratic e.g. cosine cost.

@selmanozleyen
Copy link
Collaborator

solved with #677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants