You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, first I would like to thank you for this lib, It is been useful for us here.
Said that, I would like to discuss about a possible bug I've found. But before sending my pull request I want to discuss the best solution to fix it.
I notice that the attribute "ignoreHttp1xx" of the "healthCheck" is been converted to "ignoreHttp1Xx" with the first "X" in capital letter. Based on the Marathon scheme referenced in this link https://mesosphere.github.io/marathon/docs/generated/api.html#v2_apps_post it is a boolean and the atribute "ignoreHttp1xx" with "x" in lower case.
However marathon accepts the atribute with capital "X". I'm using marathon version 0.13.0
As marathon also accepts the wrong attribute, this is generating a bug in fact. I'm creating an application that stores and validate the marathon atributes according with their scheme and it's generating a bug in my application because I'm having to create a validation too specific only for this atribute.
A simple way to see this behaviour is with this python code.
. 'httpxx'.title() and then 'http1xx'.title()
Thanks
The text was updated successfully, but these errors were encountered:
Hi, first I would like to thank you for this lib, It is been useful for us here.
Said that, I would like to discuss about a possible bug I've found. But before sending my pull request I want to discuss the best solution to fix it.
I notice that the attribute "ignoreHttp1xx" of the "healthCheck" is been converted to "ignoreHttp1Xx" with the first "X" in capital letter. Based on the Marathon scheme referenced in this link https://mesosphere.github.io/marathon/docs/generated/api.html#v2_apps_post it is a boolean and the atribute "ignoreHttp1xx" with "x" in lower case.
However marathon accepts the atribute with capital "X". I'm using marathon version 0.13.0
After analysing the results, I look into the library code and realized that the problem is in the native python string method "w.tittle()" line https://github.com/thefactory/marathon-python/blob/master/marathon/util.py#L59
I've developed one possible solution rewriting the method title and it is like this :
thiago@ddcc947
As marathon also accepts the wrong attribute, this is generating a bug in fact. I'm creating an application that stores and validate the marathon atributes according with their scheme and it's generating a bug in my application because I'm having to create a validation too specific only for this atribute.
A simple way to see this behaviour is with this python code.
. 'httpxx'.title() and then 'http1xx'.title()
Thanks
The text was updated successfully, but these errors were encountered: