Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c.scale_app('myapp3', 2) #102

Closed
houht opened this issue May 12, 2016 · 3 comments
Closed

c.scale_app('myapp3', 2) #102

houht opened this issue May 12, 2016 · 3 comments

Comments

@houht
Copy link

houht commented May 12, 2016

in README.md example:

c.scale_app('myapp3', 2)

Maybe a total of 2, instead of 3?

@solarkennedy
Copy link
Contributor

Can you tell me more or make a PR?

@houht
Copy link
Author

houht commented May 13, 2016

from marathon import MarathonClient
c = MarathonClient('http://10.0.2.47:8090')
from marathon.models import MarathonApp
c.create_app('myapp3', MarathonApp(cmd='sleep 100', mem=16, cpus=1))
MarathonApp::/myapp3
c.get_app('myapp3').instances
1
c.scale_app('myapp3', 2)
{u'deploymentId': u'8a213b34-97b6-40d0-bb93-ba18e9578bb0', u'version': u'2016-05-13T01:30:22.661Z'}
c.get_app('myapp3').instances
2

########################################################

in your README.md example:

c.get_app('myapp3').instances
1
c.scale_app('myapp3', 2)
{'deploymentId': '611b89e3-99f2-4d8a-afe1-ec0b83fdbb88', 'version': '2014-08-26T07:40:20.121Z'}
c.get_app('myapp3').instances
3

so in scale_app function , the inside of the parameter should be the final number of instances

@solarkennedy
Copy link
Contributor

Fixed. In the future feel free to simply open a PR directly with a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants