Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider not allowing the same given instance to be used more than once #3

Closed
theangrydev opened this issue Oct 14, 2016 · 1 comment
Closed

Consider not allowing the same given instance to be used more than once #3

theangrydev opened this issue Oct 14, 2016 · 1 comment
Labels
enhancement

Comments

@theangrydev
Copy link
Owner

The problem is that givens are usually implemented as mutable builders and so using the same instance more than once can lead to accidental shared state between them. First think about whether using the same instance would ever be desirable though.
@theangrydev
Copy link
Owner Author

Implemented in 4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@theangrydev