-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The online demo doesn't seem to match the actual source code #2
Comments
Hey! There is no polling! If you look carefully you can find the module that also uses websockets: collaborative.ts |
It seems that if Also worth mentioning is that It might be that you can get non-polling behavior with direct port connection. |
The demo at https://codepen.io/thealmarques/pen/YzqOrWV seems to have |
In addition, running the server code with
I think this is a bug in This crash happens when I run the server behind HAProxy but it suggests that if the browser client TCP/IP traffic looks similar to HAProxy traffic in some situations, the server would also crash with direct client connection. |
Hi @mikkorantalainen, did you ever get this to work? I'm looking to implement this in a project, but I wonder if the project is dead. Thanks. |
The demo at https://codepen.io/thealmarques/full/YzqOrWV seems to use websocket connections but the code published at https://github.com/thealmarques/tinymce-collaborative-editing-plugin seems to use polling instead.
Is this intentional? I would have expected the published code to match the published demo but it doesn't look like it.
The text was updated successfully, but these errors were encountered: