Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accessibility] Tabindex should never be >0 #26

Closed
whimsicallyson opened this issue Jan 26, 2023 · 3 comments
Closed

[Accessibility] Tabindex should never be >0 #26

whimsicallyson opened this issue Jan 26, 2023 · 3 comments

Comments

@whimsicallyson
Copy link

https://github.com/theKashey/vue-focus-lock/blob/master/src/Lock.vue#L4 has a tabindex of 1 when focus guards are active (by default). WCAG states that tabindex > 0 should never be used, see this explanation
@theKashey
Copy link
Owner

Linking a similar issue from sibling solution - theKashey/react-focus-lock#32

@theKashey
Copy link
Owner

fixed in v2.0.1

@whimsicallyson
Copy link
Author

Hi again -
I'm not sure this change is actually a functional solution. Check out https://codesandbox.io/s/vue-focus-lock-forked-1f7gko, which is your original sandbox with vue-focus-lock updated to 2.0.1. It doesn't seem like you can actually tab through anymore, with or without the focus guards enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theKashey @whimsicallyson