-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react imported component and future upgrades #230
Comments
I might add a few helpers to allow some fancy/handy operations, but so far it's just working. But that's all - nothing planned for the core functionality. |
Okay, I can confirm that it's working flawlessly in our large e-commerce platform for 3 years already, with no problems at all. It has problems with TS types from React 18. ImportedController and ImportedStream components do not have children types which is required in R18 but is not a big deal. Also we thought that this library will be no longer required after migration to R18, but that is not true, what you @theKashey pointed here and also here Also, we try to migrate from renderToString to streams but with no success. In the past, we thought this library was a blocker but now we think is still a problem with React itself, or with our extremely large codebase. So @theKashey thank you so much, for your work on lazy/async imports in general for react community :) |
@KoderFPV - I'll look into type issue but R18 streaming is a little more complicated problem - even emotion hasn't figured it out |
ok, thanks! |
Hi,
Is it any plan to release a new version of this library someday? It's one of the oldest library in my project and I wonder what to do with that :) Does it even need updates?
Thanks
The text was updated successfully, but these errors were encountered: