This repository has been archived by the owner on Dec 22, 2020. It is now read-only.
Add event ticket block #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitogh
added
the
status:code-review
paulmskim
added
review:merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new child block that is part of tickets block, this child block comes with all the godies from a block like rearrange inside of the parent block,
This one, adds an issue with the rendering of the SVG icons and also the add new item is not available for any other block that is not a paragraph, there's a core issue to keep track of this and a TODO anotation has been aded into the code to update when this one is resolved.
GH issue in core: WordPress/gutenberg#8589
Ticket: https://central.tri.be/issues/113737
Another note about this one is no changelog entry has been added as the block itself for now is a placeholder for the FE layout