Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FILE_ON_SAVING_ERROR is not defined #1379

Closed
sevmonster opened this issue Jan 2, 2024 · 0 comments
Closed

FILE_ON_SAVING_ERROR is not defined #1379

sevmonster opened this issue Jan 2, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@sevmonster
Copy link

sevmonster commented Jan 2, 2024

$iClientError = static::FILE_ON_SAVING_ERROR;

Old code from Rainloop?

This issue results in not getting a meaningful error message for the user when the Upload endpoint returns an error:

{"Action":"Upload","Result":false,"ErrorCode":999,"ErrorMessage":"0 - Undefined constant RainLoop\\Enumerations\\UploadError::FILE_ON_SAVING_ERROR","ErrorMessageAdditional":""}

Also, even if this is corrected to use ON_SAVING and a proper JSON is returned, the attachment tooltip doesn't actually use it:

{"Action":"Upload","Result":{"ErrorCode":1002,"Error":"Error saving file"}}

image

@the-djmaze the-djmaze added the bug Something isn't working label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants