Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I think the k-path visualization utilities for band plots are great, and I wanted to add a capability for plotting heatmaps, which can be helpful to visualize spectral densities. This pr refactors the k-path plotting code to make this additional capability a straightforward extension of the existing code. An example of what it can do follows from the tutorial in the documentation, which sets up the following
If we now define a spectral density
and evaluate it on a discretization
this pr allows plotting with the following command
and it is also possible to overlay multiple heatmaps with different colors, although what to do with the colorbar in this situation is undefined
I hope this is useful and I am happy to take comments on how to tweak this.
I was also hoping to ask a side question: what does the Makie extension provide?