Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Miner docs #481

Merged
merged 4 commits into from
Aug 23, 2021
Merged

Miner docs #481

merged 4 commits into from
Aug 23, 2021

Conversation

hanchon
Copy link
Contributor

@hanchon hanchon commented Aug 23, 2021

Closes: #477

Description

Miner RPC docs updated.
This PR also includes a fix to use the current configuration instead of the default when reading the configuration, to avoid overwriting the user configuration when saving the new gas price to disk.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@hanchon
Copy link
Contributor Author

hanchon commented Aug 23, 2021

Should I also update the Changelog file with this fix? More info on the issue #477

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK thanks!

@fedekunze
Copy link
Contributor

Should I also update the Changelog file with this fix? More info on the issue #477

@hanchon yes, if possible

@hanchon
Copy link
Contributor Author

hanchon commented Aug 23, 2021

Should I also update the Changelog file with this fix? More info on the issue #477

@hanchon yes, if possible

Fix added to the Changelog

@fedekunze fedekunze merged commit 204c361 into evmos:main Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add miner_ endpoints to docs
3 participants