go.mod: bump Prometheus dependency #7769
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
force-pushed
the
bump_prom_gomod
branch
3 times, most recently
from
115a4ed to
7ca8121
Compare
Bump Prometheus go.mod dependency. Pointed promql-engine to thanos-io/promql-engine#488 to fix the build error. Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
force-pushed
the
bump_prom_gomod
branch
from
7ca8121 to
f308c12
Compare
fpetkovski
reviewed
Sep 23, 2024
| github.com/prometheus/exporter-toolkit v0.12.0 | ||
| // Prometheus maps version 2.x.y to tags v0.x.y. | ||
| github.com/prometheus/prometheus v0.53.2-0.20240718123124-e9dec5fc537b | ||
| github.com/prometheus/prometheus v0.300.0-beta.0.0.20240919223826-005bd33fe229 |
Contributor
There was a problem hiding this comment.
I wonder if we should update to latest v2 to avoid potential bugs which haven't been ironed out yet.
Member
Author
|
Done in #7813 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump Prometheus go.mod dependency.