Fix race condition in pool.BucketedBytes #4095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <[email protected]>
3 tasks
kakkoyun
approved these changes
Apr 22, 2021
|
The Github CI seems broken and failures are not related, so merging this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We're reviewing #3937 and we found a race condition introduced in
pool.BucketedBytes.Put(). If the input buffer is larger than the largest bucket size, thenp.usedTotalis modified outside the lock.In this PR I'm rolling back the change done in #3937 which I think was unnecessary. Before the lock only
p.sizesandp.buckets[i]are accessed:p.sizesdoesn't change andp.buckets[i](which is async.Pool) is thread safe.Verification
N/A