Commit 54d96ef
committed
Do not return pointers from windowing functions
Commit c2f322e introduced large regressions
since due to two changes:
* Changed return values of windowing functions from float64 to *float64, causing
excessive allocations.
* Added an expensive check on the hot path for a condition that could be calculated
once for the entire query.
This commit reverts that changes and adds a better way to handle cases where both
float and histogram values are missing, but there is no error in the evaluation.
Signed-off-by: Filip Petkovski <[email protected]>1 parent 9405e06 commit 54d96ef
File tree
5 files changed
+127
-157
lines changed- execution/scan
- ringbuffer
- storage/prometheus
5 files changed
+127
-157
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
201 | 201 | | |
202 | 202 | | |
203 | 203 | | |
204 | | - | |
205 | | - | |
| 204 | + | |
| 205 | + | |
206 | 206 | | |
207 | 207 | | |
208 | 208 | | |
| |||
0 commit comments