Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate switching to heap allocated board in the myopic-board crate API #46

Open
th0masb opened this issue Dec 8, 2020 · 0 comments

Comments

@th0masb
Copy link
Owner

th0masb commented Dec 8, 2020

At the moment there are several places in the myopic-board crate where we return an explicit implementation type allocated on the stack MutBoardImpl. It makes more sense from a SWE perspective to return the generic trait type MutBoard which forces returning generic a fat pointer to the heap allocated object Box<dyn Mutboard>. All our generic methods defined elsewhere should work and we can probably remove the awkward parameterization on the EvalBoard trait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant