[in-app-menu] add hide icon option #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when item weren't initially rendered because the window was too small, but were then accessed via the arrow keys - backgrounds was missing
Araxeus
force-pushed
the
in-app-menu-hide-icon-option
branch
from
faf009c to
8000a83
Compare
Araxeus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: in-app-menu hideIcon option :
allows hiding the app icon from the titlebar (this + hideMenu option makes PiP mode really smooth looking)
fix: in-app-menu bg color edge case :
when elements weren't initially rendered because the window was too small, but were then accessed via the arrow keys - backgrounds were missing for the newly rendered elements