Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove open dependency from last-fm plugin #262

Merged
merged 2 commits into from
May 8, 2021
Merged

remove open dependency from last-fm plugin #262

merged 2 commits into from
May 8, 2021

Conversation

Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented May 7, 2021 •
edited
Loading

Replaced by Electron's shell.openExternal

Closes #261
Should also close #169

@Araxeus Araxeus changed the title remove open dependency remove open dependency from last-fm plugin May 8, 2021
@Araxeus Araxeus mentioned this pull request May 8, 2021
Closed
th-ch
th-ch approved these changes May 8, 2021
View reviewed changes
Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the improvement!

@th-ch th-ch merged commit d634c41 into th-ch:master May 8, 2021
@Araxeus Araxeus deleted the remove-`open`-dependency branch May 8, 2021 20:14
@Araxeus Araxeus mentioned this pull request May 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@th-ch th-ch th-ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

last-fm "open" npm dependency [Feature Request] Last.fm Scrobbler Integration.
2 participants
@Araxeus @th-ch