Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved songinfo provider, by using the data from the '/player' request #194

Merged
merged 3 commits into from
Mar 28, 2021
Merged

Improved songinfo provider, by using the data from the '/player' request #194

merged 3 commits into from
Mar 28, 2021

Conversation

semvis123
Copy link
Contributor

This provides more reliable song information,
Note: songinfo object has been changed a bit,

views: String -> Integer
likes: String -> Removed (not enough information to provide this reliably)
uploadDate: Undefined -> String

I also updated the Discord plugin

See #176

th-ch
th-ch approved these changes Mar 28, 2021
View reviewed changes
Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution, merging! ✅

providers/song-info.js
@@ -1,73 +1,20 @@
const { ipcMain } = require("electron");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the 2 electron imports could be bundled in one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh whoops, didn’t spot this one

@th-ch th-ch merged commit b8b1ae7 into th-ch:master Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@th-ch th-ch th-ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@semvis123 @th-ch