Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add prh to message #42

Merged
merged 2 commits into from
Jul 23, 2018
Merged

Feature: add prh to message #42

merged 2 commits into from
Jul 23, 2018

Conversation

Leko
Copy link
Contributor

@Leko Leko commented Jul 23, 2018

Fixed #5

Changes

Added prh field to message if exists.

Example (prh field exists):

version: 1
rules:
  - expected: デフォルト
    pattern:  ディフォルト
    prh: 表記をデフォルトに統一してください
ディフォルト => デフォルト
表記をデフォルトに統一してください

Example (prh not exists):

version: 1
rules:
  - expected: jQuery
ＪＱＵＥＲＹ => jQuery

azu
azu reviewed Jul 23, 2018
View reviewed changes
Copy link
Member

@azu azu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azu azu merged commit 3a786a3 into textlint-rule:master Jul 23, 2018
@Leko Leko deleted the feature-prh-message branch July 23, 2018 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azu azu azu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leko @azu