Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid ERR_TLS_CERT_ALTNAME_INVALID when redirected url #126

Merged
merged 5 commits into from
Nov 28, 2019

Conversation

azu
Copy link
Member

@azu azu commented Nov 28, 2019

Always set valid HOST for fetch's url.

Error on following case:

  1. https://example.com
  2. Redirect => https://new.example.com/

First fetch's Host is example.com, but Second fetch's Host should be new.example.com.

Current use same Host for new.example.com. It is invalid host name.

Invalid Host make following Error

13:124 error https://www.consul.io/intro/getting-started/kv.html is dead. (request to https://learn.hashicorp.com/consul/getting-started/kv.html failed, reason: Hostname/IP does not match certificate's altnames: Host: www.consul.io. is not in the cert's altnames: DNS:*.netlify.com, DNS:netlify.com) no-dead-link

fix #125

@azu
Copy link
Member Author

azu commented Nov 28, 2019

fmm, timeout erro

@azu azu merged commit 45a053d into master Nov 28, 2019
@azu azu deleted the redirected-handling branch November 28, 2019 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignoreRedirects fails due to missing host in the certificate's altname
1 participant