Add linter checks.

Author: Denis Krivak

.golangci.yml

@@ -0,0 +1,59 @@
+run:
+  concurrency: 2
+  deadline: 5m
+
+skip-dirs:
+  - path: ./testdata/
+
+linters:
+  disable-all: true
+  enable:
+    - deadcode
+    - errcheck
+    - gosimple
+    - govet
+    - ineffassign
+    - staticcheck
+    - structcheck
+    - typecheck
+    - unused
+    - varcheck
+    - bodyclose
+    - depguard
+    - dogsled
+    - dupl
+    - funlen
+    - gochecknoinits
+    - goconst
+    - gocritic
+    - gocyclo
+    - godot
+    - gofmt
+    - goimports
+    - golint
+    - gomnd
+    - gomodguard
+    - goprintffuncname
+    - gosec
+    - lll
+    - maligned
+    - misspell
+    - nakedret
+    - nestif
+    - prealloc
+    - rowserrcheck
+    - scopelint
+    - stylecheck
+    - unconvert
+    - unparam
+    - whitespace
+
+issues:
+  exclude-use-default: false
+  exclude-rules:
+    - path: _test\.go
+      linters:
+        - funlen
+    - path: cmd/godot/main\.go
+      linters:
+        - gomnd

Makefile

@@ -2,6 +2,10 @@
 test:
 	go test ./...
 
+.PHONY: lint
+lint:
+	@ golangci-lint run
+
 .PHONY: build
 build:
 	go build -o godot ./cmd/godot

cmd/godot/main.go

@@ -24,7 +24,7 @@ Options:
 
 func main() {
 	if len(os.Args) < 2 {
-		fatal(usage)
+		fatalf(usage)
 	}
 	if os.Args[1] == "-h" || os.Args[1] == "--help" {
 		fmt.Println(usage)
@@ -35,14 +35,14 @@ func main() {
 		os.Exit(0)
 	}
 	if strings.HasPrefix(os.Args[1], "-") && os.Args[1] != "-a" && os.Args[1] == "--all" {
-		fatal("Unknown flag")
+		fatalf("Unknown flag")
 	}
 
 	var settings godot.Settings
 	input := os.Args[1:]
 	if os.Args[1] == "-a" || os.Args[1] == "--all" {
 		if len(os.Args) < 3 {
-			fatal(usage)
+			fatalf(usage)
 		}
 		settings.CheckAll = true
 		input = os.Args[2:]
@@ -53,12 +53,12 @@ func main() {
 
 	for _, path := range input {
 		if _, err := os.Stat(path); os.IsNotExist(err) {
-			fatal("Path %s does not exist", path)
+			fatalf("Path %s does not exist", path)
 		}
 		for f := range findFiles(path) {
 			file, err := parser.ParseFile(fset, f, nil, parser.ParseComments)
 			if err != nil {
-				fatal("Failed to parse file %s: %v", path, err)
+				fatalf("Failed to parse file %s: %v", path, err)
 			}
 			files = append(files, file)
 		}
@@ -88,14 +88,14 @@ func findFiles(root string) chan string {
 			return nil
 		})
 		if err != nil {
-			fatal("Failed to get files from directory: %v", err)
+			fatalf("Failed to get files from directory: %v", err)
 		}
 	}()
 
 	return out
 }
 
-func fatal(format string, args ...interface{}) {
+func fatalf(format string, args ...interface{}) {
 	fmt.Printf(format+"\n", args...)
 	os.Exit(1)
 }