-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JPMS support #2727
Comments
What if you disable default listeners? |
@juherr It works fine as a workaround, but has the undesirable side-effect of disabling other remaining listeners that might be enabled by default. Please let me know when I can test JPMS support without this workaround. Thank you. |
is this related to #2308 ? |
@cowwoc - Can you please help share a sample project that can be used to reproduce this issue ? @wakingrufus - I am not sure if they are related to each other. #2308 is because of the way in which we attempt to locate classes. |
Are there any plans to modularize the project by adding the |
@bhuntay yes we do. Just havent managed to get around to this. Would you be willing to help create a Pull Request for this? |
@krmahadevan sure I can take a look |
Running into some issues with the
Hoping that javax-inject/javax-inject#33 fixes the issue or I will try to follow some other approach |
Sorry. I don't have a project handy to reproduce this. Hopefully others can provide an example the next time this happens to them. |
@krmahadevan would it be better to switch to |
@bhuntay would you know if that would hurt backward compatibility? We dont want to inconvenience our users by having them fix the package structure because of the jakarta annotations. I dont think it should be a problem but please do check and confirm. |
I think the Nullable/NonNullable annotations should not have an impact. But, I will look into it further before making any such changes. |
@krmahadevan In the process of migrating a Gradle project to use JPMS, I utilized the Extra Java Module Info Gradle plugin to convert any transitive modules such as I added |
The internal package is not an issue. It could be an inner package of the module. @bhuntay Would you like to propose a pull request fixing that? |
sure @juherr guess I will leave the core api packages untouched so as to not make it a breaking change |
For what it's worth, the following works for me:
Unfortunately, we need to export
I suggest moving this interface out of the internal package. |
TestNG Version
7.5
Expected behavior
TestNG runs tests.
Actual behavior
TestNG throws an exception:
The problem only occurs if the code being tested is a Java module (has
module-info.java
defined). The problem does not occur ifmodule-info.java
is not present, but I want to run tests as a module.Is the issue reproducible on runner?
The text was updated successfully, but these errors were encountered: