-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(upload): accept filter option #562
Conversation
Codecov Report
@@ Coverage Diff @@
## master #562 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 706 717 +11
Branches 222 226 +4
=========================================
+ Hits 706 717 +11
Continue to review full report at Codecov.
|
Co-authored-by: Philipp Fritsche <[email protected]>
It's all good from my side regarding the filter option |
🎉 This PR is included in version 12.8.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What:
Add
applyAccept
option touserEvent.upload
that defaults tofalse
.Why:
Filtering the files for the the input causes problems for those testing their own filters.
#558 (comment)
Those who want to test their accept attributes can opt-in per:
How:
Add an options parameter to the API.
Checklist: