Add type support for {home} and {end} #536
Conversation
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 692 696 +4
Branches 216 218 +2
=========================================
+ Hits 692 696 +4
Continue to review full report at Codecov.
|
src/keys/navigation-key.js
Outdated
| Home: { | ||
| keyCode: 35, | ||
| }, | ||
| End: { | ||
| keyCode: 36, | ||
| }, |
There was a problem hiding this comment.
Following keycode.info's table, those keys are inverted is it right?
There was a problem hiding this comment.
@luistak I've corrected the blunder.
|
Omg. Dyslexia strikes again. Let me fix that. Good catch.
…On Fri, Jan 8, 2021 at 9:51 AM Luís Takahashi ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/keys/navigation-key.js
<#536 (comment)>
:
> + Home: {
+ keyCode: 35,
+ },
+ End: {
+ keyCode: 36,
+ },
Following keycode.info's table, those keys are inverted is it right?
[image: image]
<https://user-images.githubusercontent.com/19766035/104028487-894f5c80-51a7-11eb-986d-adc36b81f082.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#536 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6475XO5CJOLVT7LZHIPELSY4LVTANCNFSM4VOSYIMA>
.
|
|
Who makes the call to merge? This has been hanging out in approved for a while. |
|
I'm no longer an active maintainer. Any maintainer is welcome to merge a PR if you feel like it's a good direction. If you run into issues, let me know. |
This comment has been minimized.
This comment has been minimized.
|
Just gave you merge access 👍 |
|
🎉 This PR is included in version 12.7.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
@all-contributors add @curiosity26 for code |
|
@nickmccurdy I've put up a pull request to add @curiosity26! 🎉 |
What: I've added support for typing the Home and End keys
Why: Per aria-role spec for listbox, Home and End are necessary inputs that need to be handled and tested. Not only that, it's common in textbox input, so why not, right?
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/listbox_role
How: Since Home and End are navigation keys, I added to the existing
navigationKeysfunction to supportHomeandEndand ensured cursor functionality worked as intended.Checklist: