fix: don't use localStorage when browser blocks access #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! The issue also mentions:
I think it would indeed be nice to show a message in the settings dialog if localStorage is disabled. Otherwise the user might not understand why their |
|
I have added this warning
|
smeijer
changed the title
|
Thanks, Marco! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #284
What:
Fix an issue when the user has disabled the use of cookies
Why:
It was an issue
How:
Before using localStorage I have check that cookies are enabled.
If cookies are disabled user settings will be reset on page refresh.
I have also added a warning on the settings
Checklist: