fix(render): Actually hydrate with given ui #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c113333:
|
Codecov Report
@@ Coverage Diff @@
## alpha #988 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 224 226 +2
Branches 46 46
=========================================
+ Hits 224 226 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 13.0.0-alpha.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
eps1lon
added a commit
to eps1lon/react-testing-library
that referenced
this pull request
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix "missing act" warnings when calling
render(ui, {container, hydrate})usingreact@alpha.Why:
Previous
hydrateRootusage was just wrong (see facebook/react#22643 for more information).How:
Call
hydrateRootwith the givenuiand wrapped inactChecklist:
[ ]Documentation added to thedocs site
[ ]TypeScript definitions updated