Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: import pretty-format from @testing-library/dom #821

Merged
merged 2 commits into from
Nov 10, 2020
Merged

fix: import pretty-format from @testing-library/dom #821

merged 2 commits into from
Nov 10, 2020

Conversation

marcosvega91
Copy link
Member

What: fix #694

Why: Because it causes type error

How: Importing the module from @testing-library/dom

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • Typescript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d8c4612:

Sandbox Source
React Configuration
react-testing-library-examples Configuration

kentcdodds
kentcdodds approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super 👍 Thanks!

@kentcdodds kentcdodds merged commit 2712dc2 into testing-library:master Nov 10, 2020
@kentcdodds
Copy link
Member

@all-contributors please add @marcosvega91 for code

@allcontributors allcontributors bot mentioned this pull request Nov 10, 2020
Merged
@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @marcosvega91! 🎉

@marcosvega91 marcosvega91 deleted the pr/pretty-format branch November 10, 2020 19:20
@samtsai
Copy link
Collaborator

samtsai commented Nov 10, 2020

Thanks @marcosvega91 this was eluding me for quite awhile!

@testing-library-bot
Copy link

🎉 This PR is included in version 11.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MatanBobi MatanBobi mentioned this pull request Nov 24, 2020
Merged
@h-gj h-gj mentioned this pull request May 24, 2024
Open
@h-gj h-gj mentioned this pull request Jun 6, 2024
Open
@h-gj h-gj mentioned this pull request Jul 12, 2024
Open
@h-gj h-gj mentioned this pull request Jul 27, 2024
Open
@h-gj h-gj mentioned this pull request Aug 23, 2024
Open
@h-gj h-gj mentioned this pull request Aug 30, 2024
Open
This was referenced Sep 13, 2024
Open
Open
@harrisonho99 harrisonho99 mentioned this pull request Sep 21, 2024
Open
@h-gj h-gj mentioned this pull request Oct 3, 2024
Open
@h-gj h-gj mentioned this pull request Nov 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot find module 'pretty-format'
4 participants
@marcosvega91 @kentcdodds @samtsai @testing-library-bot