-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export type TestingLibraryMatchers
from "./matchers"
#576
Merged
gnapse
merged 1 commit into
testing-library:main
from
jakeboone02:pr/export-main-matcher-type
Feb 1, 2024
Merged
Export type TestingLibraryMatchers
from "./matchers"
#576
gnapse
merged 1 commit into
testing-library:main
from
jakeboone02:pr/export-main-matcher-type
Feb 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
AxelEriksson0
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
gnapse
approved these changes
Feb 1, 2024
🎉 This PR is included in version 6.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@all-contributors please add @jakeboone02 for code, test |
I've put up a pull request to add @jakeboone02! 🎉 |
This was referenced Aug 13, 2024
Closed
This was referenced Sep 6, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR adds an export of the type
TestingLibraryMatchers
to the"./matchers"
export.This is a little weird because the
TestingLibraryMatchers
type is not strictly relevant to the"./matchers"
export--part of the reason #566 was submitted in the first place.TestingLibraryMatchers
really only applies to the default"."
export, but since the default export isn't a module (because it doesn't export anything),"./matchers"
is probably the right place.Why:
#566 introduced an unintended breaking change.
Checklist: