-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate ccs v3 to @adobe/css-tools v4 #470
Conversation
Note: The version 4 of |
Codecov Report
@@ Coverage Diff @@
## main #470 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 630 630
Branches 234 236 +2
=========================================
Hits 630 630
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'm not a current maintainer. If nobody merges in the next week or so though I'll go ahead and merge
… in nodejs and web browser environment)
@kentcdodds I updated the import to solve the CJS import path that I was using :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
🎉 This PR is included in version 5.16.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) | dependencies | minor | [`5.16.4` -> `5.17.0`](https://renovatebot.com/diffs/npm/@testing-library%2fjest-dom/5.16.4/5.17.0) | --- ### Release Notes <details> <summary>testing-library/jest-dom (@​testing-library/jest-dom)</summary> ### [`v5.17.0`](https://github.com/testing-library/jest-dom/releases/tag/v5.17.0) [Compare Source](testing-library/jest-dom@v5.16.5...v5.17.0) ##### Features - New `toHaveAccessibleErrorMessage` better implementing the spec, deprecate `toHaveErrorMessage` ([#​503](testing-library/jest-dom#503)) ([d717c66](testing-library/jest-dom@d717c66)) ### [`v5.16.5`](https://github.com/testing-library/jest-dom/releases/tag/v5.16.5) [Compare Source](testing-library/jest-dom@v5.16.4...v5.16.5) ##### Bug Fixes - migrate ccs v3 to [@​adobe/css-tools](https://github.com/adobe/css-tools) v4 ([#​470](testing-library/jest-dom#470)) ([948d90f](testing-library/jest-dom@948d90f)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xNDIuNSIsInVwZGF0ZWRJblZlciI6IjM4LjE0Mi41IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> Reviewed-on: https://gitea.bruyant.xyz/alexandre/PaletteSwitcher/pulls/45 Co-authored-by: Renovate <[email protected]> Co-committed-by: Renovate <[email protected]>
What:
Migrate the dependency
css
to@adobe/css
to reduce maintained dependencies.Closes #435
Why:
CSS package is not maintained anymore and has some sub-dependencies which are deprecated.
How:
Change the import
Checklist: