Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toHaveFocus): clarify message when using .not #447

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

Dennis273
Copy link
Contributor

What:

The output message is confusing when using expect(element).not.toHaveFocus()

image

Why:
To avoid confusion.

How:
By updating the output message when isNot is truthy.

image

Checklist:

  • Documentation N/A
  • Tests N/A
  • Updated Type Definitions N/A
  • Ready to be merged

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #447 (be9e2d9) into main (4d0ceeb) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #447   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          624       626    +2     
  Branches       231       233    +2     
=========================================
+ Hits           624       626    +2     
Impacted Files Coverage Δ
src/to-have-focus.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d0ceeb...be9e2d9. Read the comment docs.

@gnapse gnapse merged commit 6988a67 into testing-library:main Mar 24, 2022
@gnapse
Copy link
Member

gnapse commented Mar 24, 2022

@all-contributors please add @Dennis273 for code

@Dennis273 Dennis273 deleted the pr/to-have-focus-message branch March 24, 2022 12:57
@allcontributors
Copy link
Contributor

@gnapse

I've put up a pull request to add @Dennis273! 🎉

@github-actions
Copy link

🎉 This PR is included in version 5.16.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gnapse
Copy link
Member

gnapse commented Feb 1, 2024

@all-contributors please add @Dennis273 for code

Copy link
Contributor

@gnapse

I've put up a pull request to add @Dennis273! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants