-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update aria-query to 5.0.0 #414
Conversation
Hi, the corresponding PR was merged into dom-testing-library. Would anyone like to take a look at this PR? I think it's best if the versions stay in-sync. |
To confirm what you seem to say in the PR description: is this a breaking change to the outside world? |
Codecov Report
@@ Coverage Diff @@
## main #414 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 620 620
Branches 227 227
=========================================
Hits 620 620
Continue to review full report at Codecov.
|
I do not believe this is breaking, and a major release was not needed for dom-testing-library, see: testing-library/dom-testing-library#1058 (comment) |
@all-contributors please add @IanVS for code |
I've put up a pull request to add @IanVS! 🎉 |
Thanks @gnapse! |
🎉 This PR is included in version 5.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What:
This updates the version of
aria-query
to 5.0.0.Why:
Closes #413.
How:
This is a breaking change in that Map and Set are no longer used. But, the
roles
object that is returned has methods on it, including.get()
, which is used inroleSupportsChecked
.The only update I made to the code is to remove the
Array.from()
call, sinceroles.keys()
already returns an array now.Checklist: