Merge branch 'master' into prefer-in-document-recommended

Author: benmonro

.github/ISSUE_TEMPLATE.md

@@ -18,6 +18,7 @@ learn how: http://kcd.im/pull-request
 Relevant code or config
 
 ```javascript
+
 ```
 
 What you did:

README.md

@@ -111,6 +111,7 @@ Name | 👍 | 🔧 | Description
 [prefer-to-have-attribute](https://github.com/testing-library/eslint-plugin-jest-dom/blob/master/docs/rules/prefer-to-have-attribute.md) | 👍 | 🔧 | prefer toHaveAttribute over checking  getAttribute/hasAttribute 
 [prefer-to-have-style](https://github.com/testing-library/eslint-plugin-jest-dom/blob/master/docs/rules/prefer-to-have-style.md) | 👍 | 🔧 | prefer toHaveStyle over checking element style
 [prefer-to-have-text-content](https://github.com/testing-library/eslint-plugin-jest-dom/blob/master/docs/rules/prefer-to-have-text-content.md) | 👍 | 🔧 | Prefer toHaveTextContent over checking element.textContent
+
 <!-- __END AUTOGENERATED TABLE__ -->
 
 ## Issues

docs/rules/prefer-in-document.md

@@ -17,17 +17,32 @@ expect(queryByText("foo")).toBeNull();
 expect(queryByText("foo")).not.toBeNull();
 expect(queryByText("foo")).toBeDefined();
 expect(queryByText("foo")).not.toBeDefined();
+
+const foo = screen.getByText("foo");
+expect(foo).toHaveLength(1);
+
+const bar = screen.queryByText("bar");
+expect(bar).toHaveLength(0);
 ```
 
 Examples of **correct** code for this rule:
 
 ```js
 expect(screen.queryByText("foo")).toBeInTheDocument();
-expect(screen.queryByText("foo")).toBeInTheDocument();
-expect(queryByText("foo")).toBeInTheDocument()`;
-expect(wrapper.queryAllByTestId('foo')).toBeInTheDocument()`;
-expect(screen.getAllByLabel("foo-bar")).toHaveLength(2)`;
-expect(notAQuery('foo-bar')).toHaveLength(1)`;
+expect(await screen.findByText("foo")).toBeInTheDocument();
+expect(queryByText("foo")).toBeInTheDocument();
+expect(wrapper.queryAllByTestId("foo")).toBeInTheDocument();
+expect(screen.getAllByLabel("foo-bar")).toHaveLength(2);
+expect(notAQuery("foo-bar")).toHaveLength(1);
+
+const foo = screen.getAllByText("foo");
+expect(foo).toHaveLength(3);
+
+const bar = screen.queryByText("bar");
+expect(bar).not.toBeDefined();
+
+const baz = await screen.findByText("baz");
+expect(baz).toBeDefined()
 ```
 
 ## When Not To Use It

other/MAINTAINING.md

@@ -66,5 +66,4 @@ necessary by the git commit messages. With this in mind, **please brush up on
 
 Thank you so much for helping to maintain this project!
 
-[commit]:
-  https://github.com/conventional-changelog-archived-repos/conventional-changelog-angular/blob/ed32559941719a130bb0327f886d6a32a8cbc2ba/convention.md
+[commit]: https://github.com/conventional-changelog-archived-repos/conventional-changelog-angular/blob/ed32559941719a130bb0327f886d6a32a8cbc2ba/convention.md

package.json

@@ -59,7 +59,8 @@
     "rules": {
       "babel/quotes": "off",
       "max-lines-per-function": "off",
-      "testing-library/no-dom-import": "off"
+      "testing-library/no-dom-import": "off",
+      "consistent-return": "off"
     }
   },
   "eslintIgnore": [

smoke-test/eslint-remote-tester.config.js

@@ -20,21 +20,6 @@ module.exports = {
         'bundle\\.js',
         'react-dom\\.development\\.js',
         '\\.min\\.js', // Any *.min.js
-
-        // Project specific ignores
-        'codesandbox-client/packages/app/static/js',
-        'codesandbox-client/standalone-packages',
-        'dockunit/platform/assets',
-        'hyper/bin',
-        'react-solitaire/lib/index\\.js',
-        'Khan/perseus/lib',
-        'glortho/react-keydown/example/public',
-        'reach/reach-ui/packages/combobox/examples/cities\\.ts',
-        'reach/reach-ui/website/src/components/cities\\.js',
-        'reach/reach-ui/website/static/router/static',
-        'Automattic/wp-calypso/client/components/phone-input/data\\.js',
-        'test262-main\\.ts',
-        'sample_vis\\.test\\.mocks\\.ts',
     ].join('|')})`,
 
     /** Empty array since we are only interested in linter crashes */
@@ -67,7 +52,7 @@ module.exports = {
             'plugin:jest-dom/recommended',
         ],
         rules: {
-            'prefer-in-document': 'error'
+            'jest-dom/prefer-in-document': 'error'
         },
     },
 };