Skip to content
This repository has been archived by the owner on Sep 6, 2023. It is now read-only.

Get ready for npm 7 #63

Closed
Bnaya opened this issue Oct 14, 2020 · 2 comments · Fixed by #86
Closed

Get ready for npm 7 #63

Bnaya opened this issue Oct 14, 2020 · 2 comments · Fixed by #86

Comments

@Bnaya
Copy link
Contributor

Bnaya commented Oct 14, 2020

npm 7 is going to automatically install peer dependencies.
Currently we have both puppeteer and playwright as peer deps,
and we expect the user to install & use only one of them.
The coming npm 7 feature will also the other package for the user, which is not desirable.

@gioragutt
Copy link
Contributor

How about optionalDependencies?

@Bnaya
Copy link
Contributor Author

Bnaya commented Nov 16, 2020

Optional peer deps using peerDependenciesMeta might help us, but it's not very documented

refs:
https://classic.yarnpkg.com/en/docs/package-json/#toc-peerdependenciesmeta
npm/rfcs#221
npm/cli#1247

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants