Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support script/ along with scripts/ by default #52

Closed
jasonkarns opened this issue Jan 13, 2018 · 2 comments · Fixed by #72
Closed

Support script/ along with scripts/ by default #52

jasonkarns opened this issue Jan 13, 2018 · 2 comments · Fixed by #72
Assignees

Comments

@jasonkarns
Copy link
Member

GitHub's ScriptsToRuleThemAll is picking up steam as a conventional way of having scripts in a standard location across different language stacks. They use script/ as their conventional directory.

And anecdotally, a lot of nix devs I know seem to default to putting their shell scripts in script/ as well.

I don't know if script/ is some long standing convention of sysadmins or a recent conventional, but it's seemingly more common than scripts/ as a directory.

I know that the script directory can be configured manually, but convention would be better. And since script/ is the same as scripts/ in spirit ;), I propose we also allow script/ to be used by default, without the manual configuration. Implementation would just use script/ as a fallback. (Or perhaps prefer script/?) I think odds of repos having both script/ and scripts/ is virtually nil, so I don't foresee any issue with accepting either.

I'd also support migrating towards script/ as a default, and doing away with scripts/ at some point in the future. But supporting both for a while would allow for backwards compatibility.

@jasonkarns jasonkarns self-assigned this Jan 13, 2018
@searls
Copy link
Member

searls commented Jan 16, 2018

👍 I'd support this. In fact, before reading this, I would have assumed we already named it script.

Would merge a PR that just looked up both scripts and script (and script-win, I guess)

@texastoland
Copy link
Contributor

👍🏽 I like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants