Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance #34

Closed
benadamstyles opened this issue Apr 22, 2016 · 2 comments
Closed

Performance #34

benadamstyles opened this issue Apr 22, 2016 · 2 comments

Comments

@benadamstyles
Copy link

Is it possible that using scripty over a raw npm script would affect performance negatively? I'm seeing a ~10% performance hit and the only thing I'm changing is whether I'm using scripty or not. Sorry I don't have any solid data/benchmarks for this 😕

@searls
Copy link
Member

searls commented Apr 22, 2016

Well, it definitely adds a level of indirection, and it does some File I/O to figure out which scripts to spawn, so I'd expect there to be some start-up hit. As for long-running scripts, I can't imagine what'd cause it to be any slower than npm run since that's also shelling out to a sub-process with child_process.spawn.

I'll close for now in lieu of solid benchmarks / profiling indicating something we can do to improve or optimize scripty.

@searls searls closed this as completed Apr 22, 2016
@benadamstyles
Copy link
Author

Ok thanks for replying, I'll keep an eye on it and if it does seem to be a serious issue I'll run some proper benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants