Add logging, remove crayon and blindspin #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tillahoffmann
left a comment
tillahoffmann
left a comment
There was a problem hiding this comment.
Yes, good point. A few small suggestions.
testcontainers/core/container.py
Outdated
| print("") | ||
| print("Container started: ", | ||
| crayons.yellow(self._container.short_id, bold=True)) | ||
| logger.info("") |
Contributor
There was a problem hiding this comment.
Suggested change
| logger.info("") |
testcontainers/core/container.py
Outdated
| volumes=self.volumes, | ||
| **self._kargs | ||
| ) | ||
| logger.info("") |
Contributor
There was a problem hiding this comment.
Suggested change
| logger.info("") |
testcontainers/core/container.py
Outdated
| print("Container started: ", | ||
| crayons.yellow(self._container.short_id, bold=True)) | ||
| logger.info("") | ||
| logger.info("{} {}".format("Pulling image", self.image)) |
Contributor
There was a problem hiding this comment.
Let's use the standard approach for parameter substitution in logs throughout.
tillahoffmann
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes some changes for discussion.
I really enjoy using testcontainers and have used them in both Go and Java. In my opinion, there are some things missing or out of scope for this python implementation.
print()inside of python modules and one should always use theloggingmodule so the end user can decide for himself if and what messages are of interest and should be logged.Let me know your point on this.
Best, Roman