DockerComposeContainer with Selenium Grid example

[sskorol]

Hi @rnorth, thanks for the good project!

However, I have several questions:

• Do you have any samples of using DockerComposeContainer with Selenium Grid? I want to use official selenium images (hub, node-firefox-debug / node-chrome-debug) as separate containers to be able to scale them via docker-compose scale option. Not really sure if it's possible to pass scale image=N cmd args to already started containers.
• Are you planning to add TestNG support? I noticed that you strictly dependent from JUnit Rules to be able to start / stop containers before / after test execution. What would be an effort to create a similar TestNG runner?

[rnorth]

Hi,
Thank you :)

These are great questions!

• No, I've not got an example of that use case, but it's an interesting one. I think that, probably, Testcontainers should have a .scale(String name, int size) method on the DockerComposeContainer class to allow containers to be scaled. There will be a bit of work needed under the covers to make this work, but it'd be nice.
• Yes, with hindsight I wish I'd kept JUnit support as a separate module. For a future release, I think I'd like to break out JUnit support from core; this would make it much easier to use other test frameworks. In the meantime you could call the start() and stop() methods on a container object from TestNG BeforeTest/AfterTest methods. Of course, Testcontainers will still carry a JUnit classpath dependency, which is ugly...

Thanks
Richard

[sskorol]

@rnorth thanks! Would be great to see these features soon.

By the way, I also noticed that BrowserWebDriverContainer is dependent from selenium/standalone-firefox(chrome)-debug images. With current approach we're able to run tests only in a single browser. But the main selenium grid's feature is in scaling. Would be nice to see some more generic container + specific child implementations. E.g. splitted hub / node / standalone containers, which could have existing class as a Base one (with some minimal updates).

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

[stale]

This issue has been automatically closed due to inactivity. We apologise if this is still an active problem for you, and would ask you to re-open the issue if this is the case.