Changed Oracle thin URL for support Oracle 11 and 12 XE with SID #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsideup
approved these changes
Jul 10, 2018
rnorth
approved these changes
Jul 10, 2018
|
LGTM - thank you for the contribution @sandrogiacom! I'll merge. |
|
Released in 1.8.1! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the thin URL format according to Oracle documentation to support 11 and 12XE versions using SID. Changed because the current format does not connect in Oracle 12 XE
Used the images below for tests:
wnameless/oracle-xe-11g:latest
pengbai/docker-oracle-12c-r1
https://docs.oracle.com/database/121/JJDBC/urls.htm#JJDBC28275