-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up automatically when container stopped #552
Comments
hi @alexcase52, Do you want it to be cleaned during the tests or after? |
Immediately once the container stopped is better for me - it may retain some space. But usually it is no so important when. |
We already have such a functionality in place (Reaper) and we will soon add a more reliable component for this running outside the JVM. What functionality are you missing with the current implementation? |
OK if you already have it. I just see some strange exited containers appeared after I started experiments with testcontainers. In my case there were postgres containers. |
This will currently happen if you i.e. SIGKILL the JVM process. |
Maybe I had this case and some guard here is desirable. Quite often I could terminate tests e.g. while debugging if I see that something failed and I've got what was wrong. Not sure how this docker --rm flag will behave. |
@alexcase52 |
Thanks, will wait for this change |
I believe this can be closed now as #545 is released in 1.6.0 |
Closed by #545 |
Hi, is there a way to properly clean up once container stopped?
Would be good to have it as a setter in GenericContainer.
It could rely on this
The text was updated successfully, but these errors were encountered: