Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust wording of pre-flight check messages to be clearer #457

Merged
merged 2 commits into from
Sep 18, 2017
Merged

Adjust wording of pre-flight check messages to be clearer #457

merged 2 commits into from
Sep 18, 2017

Conversation

rnorth
Copy link
Member

@rnorth rnorth commented Sep 18, 2017

when presented as an AssertionError. Replaces #436.

@rnorth
Adjust wording of pre-flight check messages to be clearer
bd40250 
when presented as an AssertionError. Replaces #436.
@rnorth rnorth mentioned this pull request Sep 18, 2017
Closed
bsideup
bsideup approved these changes Sep 18, 2017
View reviewed changes
Copy link
Member

@bsideup bsideup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@rnorth
Copy link
Member Author

rnorth commented Sep 18, 2017

Thanks @bsideup :)

@rnorth rnorth merged commit d2906fd into master Sep 18, 2017
@rnorth rnorth deleted the clarify-check-messages branch September 18, 2017 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsideup bsideup bsideup approved these changes

@kiview kiview Awaiting requested review from kiview

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rnorth @bsideup