Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to provide classloader for JdbcDatabaseContainer #344

Closed
npetzall opened this issue May 23, 2017 · 12 comments
Closed

Ability to provide classloader for JdbcDatabaseContainer #344

npetzall opened this issue May 23, 2017 · 12 comments
Labels

Comments

@npetzall
Copy link

Would be nice if one could supply a Driver classloader to the JdbcDatabaseContainer.

This is more or less specific to Oracle test container. Since it's problematic to have the proprietary drivers in a repository.

@npetzall
Copy link
Author

npetzall commented May 23, 2017

Haven't checked might be possible if it used thread context classloader.

@npetzall
Copy link
Author

Ok to do PR?

@kiview
Copy link
Member

kiview commented May 23, 2017

Everyone I know who is working with Oracle JDBC drivers has them in their own Artifactory or deploys them in the local Maven repository on the dev machines. So TBH, I'm not sure if this would help a lot.

Could you explain your use case?

@npetzall
Copy link
Author

Use-Case:
I'm helping out on a project SchemaSpy which is open-source. We would like to be able to test Oracle.
We don't want to put oracle driver on the classpath. Since one might assume it will exist on the classpath.

So we/I want to have the driver side-loaded.

@npetzall
Copy link
Author

For instance, you could in this project assume that the Oracle driver was located in ${project.baseDir}/proprietary and run Oracle tests when the driver is located in that folder. If the assumption passes. If it can't find the driver it will just ignore the test, which differs from right now as it ignores the whole module.

@npetzall
Copy link
Author

No reason to keep this open if it's not wanted.

@kiview
Copy link
Member

kiview commented May 26, 2017

Let's wait for the opinion of @rnorth.

@rnorth
Copy link
Member

rnorth commented May 26, 2017 via email

@npetzall
Copy link
Author

@rnorth
Yepp, I've done it in my fork and I've got jitpack so I'm good.

@npetzall
Copy link
Author

npetzall commented Jun 5, 2017

@rnorth manage to solve it with maven and a cpl of settings for the failsafe plugin.
So solving 343 and we can retire the fork.
Might be able to create custom launcher for IDE so it can be run from IDE.

@stale
Copy link

stale bot commented Oct 28, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stale stale bot added the stale label Oct 28, 2018
@stale
Copy link

stale bot commented Nov 11, 2018

This issue has been automatically closed due to inactivity. We apologise if this is still an active problem for you, and would ask you to re-open the issue if this is the case.

@stale stale bot closed this as completed Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants