Rename Docker-in-Docker references #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d confusion with the DinD project which is not _quite_ the same thing (DinD is probably a _subset_ of what Testcontainers supports)
|
What do you think @bsideup - is this accurate? We support volume-mounted docker sockets, whereas DinD is something slightly different. I thought it best to change our reference here just to avoid confusion. |
|
@rnorth got your point. Yes, sounds correct, let's rename it! |
bsideup
approved these changes
Jan 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to 'running inside docker' to avoid confusion with the DinD project which is not quite the same thing (DinD is probably a subset of what Testcontainers supports)